fix(runtime): runtime mqtt client id name undefined

src/runtime-mngr/index.js

@@ -105,7 +105,7 @@ export class RuntimeMngr {
 
     // instanciate runtime messages factory
     this.rtMsgs = new RuntimeMsgs(this);
-    
+
     // create a last will message (delete runtime)
     this.lastWillStringMsg = JSON.stringify(this.rtMsgs.deleteRuntime());
 
@@ -144,7 +144,7 @@ export class RuntimeMngr {
   }
 
   async init() {
-    // mqtt connect; setup delete runtime msg as last will 
+    // mqtt connect; setup delete runtime msg as last will
     let rtMngr = this;
     this.mc = new MQTTClient({
       mqtt_host: rtMngr.mqttHost,
@@ -153,6 +153,7 @@ export class RuntimeMngr {
       onMessageCallback: rtMngr.onMqttMessage.bind(rtMngr),
       willMessage: rtMngr.lastWillStringMsg,
       willMessageTopic: rtMngr.regTopic,
+      name: rtMngr.name, // TODO(mwfarb): review
     });
 
     await this.mc.connect();
@@ -346,10 +347,10 @@ export class RuntimeMngr {
 
   getRtDbgTopic() {
     return `${this.dbgTopic}/${this.uuid}`;
-  }  
+  }
 
   /* pubsub topic where the runtime sends unregister messages (ctl_topic+module uuid) */
   getRtCtlTopic() {
     return `${this.ctlTopic}/${this.uuid}`;
-  }    
+  }
 }

src/runtime-mngr/mqtt-client.js

@@ -1,6 +1,6 @@
 /**
- * @fileoverview Paho MQTT client wrapper; 
- * The runtime manager has its own mqtt client 
+ * @fileoverview Paho MQTT client wrapper;
+ * The runtime manager has its own mqtt client
  * TODO: reconcile with other mqtt clients (main arena client, chat ?)
  *
  * Open source software under the terms in /LICENSE
@@ -12,7 +12,7 @@ import * as Paho from 'paho-mqtt'; // https://www.npmjs.com/package/paho-mqtt
 
 export default class MQTTClient {
     constructor(st) {
-  
+
       // handle default this.settings
       st = st || {};
       this.settings = {
@@ -33,30 +33,31 @@ export default class MQTTClient {
         willMessageTopic:
           st.willMessageTopic !== undefined ? st.willMessageTopic : "lastwill",
         dbg: st.dbg !== undefined ? st.dbg : false,
+        userid: st.name, // TODO(mwfarb): review
       };
-  
+
       if (this.settings.willMessage !== undefined) {
         const lw = new Paho.Message(this.settings.willMessage);
         lw.destinationName =
           st.willMessageTopic !== undefined ? st.willMessageTopic : "lwtopic";
         lw.qos = 2;
         lw.retained = false;
-  
+
         this.settings.willMessage = lw;
       }
     }
-  
+
     async connect(force = false) {
       if (this.connected == true && force == false) return;
       this.mqttc = new Paho.Client(
         this.settings.mqtt_host,
         "rtmngr-" + this.settings.userid,
-        
+
       );
-  
+
       this.mqttc.onConnectionLost = this.onConnectionLost.bind(this);
       this.mqttc.onMessageArrived = this.onMessageArrived.bind(this);
-      
+
       let _this = this;
       return new Promise(function (resolve, reject) {
         _this.mqttc.connect({
@@ -78,25 +79,25 @@ export default class MQTTClient {
         });
       });
     }
-  
+
     onConnectionLost(message) {
       console.error("MQTT Client Disconnect.");
       this.connected = false;
     }
-  
+
     subscribe(topic, qos = 0) {
       this.mqttc.subscribe(topic, qos);
     }
-  
+
     unsubscribe(topic, qos = 0) {
       this.mqttc.unsubscribe(topic);
     }
-  
+
     async publish(topic, payload, qos = 0, retained = false) {
       if (this.settings.dbg == true) console.log(`publish ${topic}: ${payload}`);
       this.mqttc.send(topic, payload, qos, retained);
     }
-  
+
     /**
      * Callback; Called when a message arrives
      */
@@ -109,9 +110,8 @@ export default class MQTTClient {
             message.payloadString +
             "\n"
         );
-  
+
       if (this.settings.onMessageCallback != undefined)
         this.settings.onMessageCallback(message);
     }
   }
-