-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Refactored topic structure for more granular flow and access #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-liang
force-pushed
the
topic-v5
branch
2 times, most recently
from
July 26, 2024 05:36
4f4afb4
to
9cab0a0
Compare
hi-liang
force-pushed
the
topic-v5
branch
20 times, most recently
from
August 6, 2024 22:46
f55e61f
to
451f5b3
Compare
- Move query selects to ready if possible - Partially init topic on ready, use live camName - use global ARENA
- Consolidate this.arena to just global ARENA
- This should be a one-time thing that happens, which may result in a race condition as seen in the chatui
- This should always trigger an update from aframe lifecycle - Removes need to jitter arena-camera ttl value
…ng ttl: 30 and not ttl: { seconds: 30 }
mwfarb
changed the title
WIP: Topic Refactor V5
feat(mqtt): Refactored topic structure for more granular flow and access
Oct 14, 2024
mwfarb
changed the title
feat(mqtt): Refactored topic structure for more granular flow and access
feat!: Refactored topic structure for more granular flow and access
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The MQTT topic structure has been changed, requiring all Python and Unity clients to upgrade.