This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Traditional module multiple select name fix #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -278,6 +278,9 @@ Selectivity.Templates = { | |||
| * mode - Mode in which select exists, single or multiple. | |||
| */ | |||
| selectCompliance: function(options) { | |||
| if (options.mode === 'multiple' && !options.name.match(/\[\]$/)) { | |||
There was a problem hiding this comment.
Why not use options.name.slice(-1) !== '[]'? That seems a bit easier for readability (and performance) than trying to parse a regular expression :)
Also, you can shorten the next line to options.name += '[]'.
There was a problem hiding this comment.
Haha, you are right. Syntax updated, synced with current master version and built. :)
Conflicts: dist/selectivity-full.min.js
|
Oops, looks like I misled you with my comment... |
arendjr
added a commit
that referenced
this pull request
Apr 30, 2015
Traditional module multiple select name fix
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arendjr I noticed I made a small mistake yesterday, so I'm correcting it now :)
<select multiple>should havenameending with[]in order to work properly with traditional forms.