Skip to content

Commit

Permalink
Change max number of rule Mems to 16
Browse files Browse the repository at this point in the history
Change max number of rule ``Mem``s from 5 to 16 (#4933)
  • Loading branch information
arendst committed Dec 22, 2019
1 parent ad4a7e9 commit c806b22
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,5 @@ The following binary downloads have been compiled with ESP8266/Arduino library c

- Change Settings text handling allowing variable length text within a total text pool of 699 characters
- Change Smoother ``Fade`` using 100Hz instead of 20Hz animation (#7179)
- Change max number of rule ``Mem``s from 5 to 16 (#4933)
- Add support for max 150 characters in command parameter strings (#3686, #4754)
1 change: 1 addition & 0 deletions tasmota/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Change Settings text handling allowing variable length text within a total text pool of 699 characters
- Change Smoother ``Fade`` using 100Hz instead of 20Hz animation (#7179)
- Change max number of rule ``Mem``s from 5 to 16 (#4933)
- Add support for max 150 characters in most command parameter strings (#3686, #4754)

## Released
Expand Down
2 changes: 1 addition & 1 deletion tasmota/tasmota.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const uint8_t MAX_PCF8574 = 8; // Max number of PCF8574 devices
const uint8_t MAX_RULE_SETS = 3; // Max number of rule sets of size 512 characters
const uint16_t MAX_RULE_SIZE = 512; // Max number of characters in rules

const uint8_t MAX_RULE_MEMS = 5; // Max number of saved vars
const uint8_t MAX_RULE_MEMS = 16; // Max number of saved vars
const uint8_t MAX_HUE_DEVICES = 15; // Max number of Philips Hue device per emulation

const char MQTT_TOKEN_PREFIX[] PROGMEM = "%prefix%"; // To be substituted by mqtt_prefix[x]
Expand Down
4 changes: 2 additions & 2 deletions tasmota/xdrv_10_rules.ino
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ char rules_vars[MAX_RULE_VARS][33] = {{ 0 }};
#if (MAX_RULE_VARS>16)
#error MAX_RULE_VARS is bigger than 16
#endif
#if (MAX_RULE_MEMS>5)
#error MAX_RULE_MEMS is bigger than 5
#if (MAX_RULE_MEMS>16)
#error MAX_RULE_MEMS is bigger than 16
#endif

/*******************************************************************************************/
Expand Down

0 comments on commit c806b22

Please sign in to comment.