Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range Extender driver xdrv_58_range_extender does not compile with core 3.0.0 #21200

Closed
Jason2866 opened this issue Apr 16, 2024 · 18 comments
Closed
Labels
migration (breaking) changes -> new concept / function work in progress Action - Work in progress

Comments

@Jason2866
Copy link
Collaborator

Jason2866 commented Apr 16, 2024

Details of failing can be seen in this GH Actions run https://github.com/Jason2866/Tasmota-build/actions/runs/8704050149/job/23871521878

@joba-1 @sillyfrog can you have a look and adopt to IDF5.1 / Arduino core 3.0.0?

@joba-1
Copy link
Contributor

joba-1 commented Apr 16, 2024

At first glance: tcpip_adapter API discontinued and replaced by ESP-NETIF :(
See https://docs.espressif.com/projects/esp-idf/en/release-v5.1/esp32/migration-guides/release-5.x/5.0/networking.html?highlight=tcp#tcp-ip-adapter

No idea how much changed. Maybe it is more or less search&replace ... and testing.

Could you please make it easy for me and post a platformio.ini or (a link to) instructions to compile locally with this new stuff? What I have working is VS Code on Linux with PlatformIO Extension and a cloned tasmota. I guess I just have to replace some platform or framework entries?

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Apr 16, 2024

Do a fresh clone of Tasmota in a different folder. Don't use your existing setup it may conflicts since the platformio setup has changed. You can use this env

[env:tasmota32-rangeextender]
extends                     = env:tasmota32_base
build_flags                 = ${env:tasmota32_base.build_flags}
                              -DFIRMWARE_TASMOTA32
                              -DUSE_WIFI_RANGE_EXTENDER
                              -DUSE_WIFI_RANGE_EXTENDER_NAPT
lib_ignore                  =
                              TTGO TWatch Library
                              Micro-RTSP

best is to place in file platformio_tasmota_cenv.ini

@joba-1
Copy link
Contributor

joba-1 commented Apr 18, 2024

Thanks,, worked - seen the same errors last evening.
Changes are definitely not just cut&paste - will need time.
For now I did not even find a way to get the ip addresses of connected clients.
Another thing is, for some non-arduino api calls you need a net device. Not sure yet where this is buried in arduino, in case I need it.
The migration "guide" is far from complete :(

@Jason2866 Jason2866 added work in progress Action - Work in progress migration (breaking) changes -> new concept / function labels Apr 18, 2024
Copy link

This issue has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label May 13, 2024
@Jason2866 Jason2866 removed the stale Action - Issue left behind - Used by the BOT to call for attention label May 13, 2024
@sillyfrog
Copy link

I noticed this has been marked stale. I have this on my radar, but it'll be a little bit before I'll have time to look at it properly... Let me know if you get very far in the meantime. Thanks!

@joba-1
Copy link
Contributor

joba-1 commented May 23, 2024

sure, I‘ll let you know of any progress (or problems, in case you have an idea). Earliest next week, nothing new so far.

Copy link

This issue has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Jun 17, 2024
@sfromis
Copy link
Contributor

sfromis commented Jun 17, 2024

Unstale, builds still failing

@github-actions github-actions bot removed the stale Action - Issue left behind - Used by the BOT to call for attention label Jun 17, 2024
Copy link

This issue has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Jul 12, 2024
@sfromis
Copy link
Contributor

sfromis commented Jul 12, 2024

Any hope of getting this feature refactored to match the API change?

@github-actions github-actions bot removed the stale Action - Issue left behind - Used by the BOT to call for attention label Jul 12, 2024
Copy link

github-actions bot commented Aug 6, 2024

This issue has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Aug 6, 2024
@Jason2866 Jason2866 removed the stale Action - Issue left behind - Used by the BOT to call for attention label Aug 6, 2024
@sfromis
Copy link
Contributor

sfromis commented Aug 6, 2024

unstale

Copy link

This issue has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Aug 31, 2024
@sfromis
Copy link
Contributor

sfromis commented Aug 31, 2024

Tickle

@github-actions github-actions bot removed the stale Action - Issue left behind - Used by the BOT to call for attention label Aug 31, 2024
@fdaubercy
Copy link

Hi.
I always have to run my rangeextender with a version older than the current one. Compiling with this option still doesn't work.
Frédéric

@Jason2866
Copy link
Collaborator Author

@fdaubercy Thats why this issue is open ;-)

@Jason2866
Copy link
Collaborator Author

Closing should be solved with #22205

@sillyfrog
Copy link

Thank you all (@Jason2866 @pharaocurt ) for helping get this sorted! (Sorry I never had a chance to get back into it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration (breaking) changes -> new concept / function work in progress Action - Work in progress
Projects
None yet
Development

No branches or pull requests

5 participants