Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FallbackTopic #538

Closed
ionciubotaru opened this issue Jun 22, 2017 · 1 comment
Closed

FallbackTopic #538

ionciubotaru opened this issue Jun 22, 2017 · 1 comment
Labels
enhancement Type - Enhancement that will be worked on

Comments

@ionciubotaru
Copy link

FallbackTopic is affected by fullTopic configuration. Ex: for FullTopic tasmota/%topic%/%prefix%/ the FallbackTopic is tasmota/cmnd/<FallbackTopic>/<command> <parameter>

I suggest, because FallbackTopic is mainly used for debugging reasons, to preserve standard configuration cmnd/<FallbackTopic>/<command> <parameter> to avoid FullTopic misconfigure issues
@arendst arendst added the enhancement Type - Enhancement that will be worked on label Jun 22, 2017
@arendst
Copy link
Owner

arendst commented Jun 22, 2017

Sounds Ok with me.

I would like to suggest to make cmnd also mandatory as it could have been misconfigured by command Prefix1.

So the total FallBackTopic string would then be cmnd/<FallbackTopic>/<command> <parameter> (Without tasmota).

If no comments I will try to implement after a week from now.

arendst added a commit that referenced this issue Jun 30, 2017
@arendst
v5.2.3
ee883bd 
5.2.3 20170630
* Change Sonoff Led color conversion code
* Fix SetOption12 handling
* Simplify auto configuration upgrade
* Add option Upgrade <version_number> to only upgrade to any higher
version (Old PR #213)
* Change FallbackTopic to cmnd/<MQTTClient>/<command> <parameter>
bypassing FullTopic and Prefix (#538)
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 6, 2018
@arendst
v5.2.3
a79cf3d 
5.2.3 20170630
* Change Sonoff Led color conversion code
* Fix SetOption12 handling
* Simplify auto configuration upgrade
* Add option Upgrade <version_number> to only upgrade to any higher
version (Old PR arendst#213)
* Change FallbackTopic to cmnd/<MQTTClient>/<command> <parameter>
bypassing FullTopic and Prefix (arendst#538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Type - Enhancement that will be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ionciubotaru @arendst