-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensor DS18x20 is selectable, even not in compiled firmware #6647
Comments
Uncomment in sonoff_template.h did solve
So it seems the if does not work |
This is as designed. When you do not select define USE_DS18x20 it will always install the single DS18B20 driver as configured in sonoff_post.h |
I feel free to ask, why? |
legacy, Legacy, LEGACY! The DS18B20 and DHT sensors were added when the Sonoff TH was introduced. This device had default support for these sensors from itead. I agree, we are now two years ahead and might conclude to abandon the single device driver in favour of the one and only multi device DS18X20 driver. |
Remove default DS18B20 driver and only support define DS18x20 (#6647)
thx! |
BUG DESCRIPTION
Choice is seen in GPIO config page even when all DS18xx drivers are not compiled in firmware.
Backlog Template; Module; GPIO
:TO REPRODUCE
Compile firmware without DS18xx driver
EXPECTED BEHAVIOUR
Choice should not appear
The text was updated successfully, but these errors were encountered: