Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance or Eliminate SetOption51 #6969

Closed
meingraham opened this issue Nov 19, 2019 · 4 comments
Closed

Enhance or Eliminate SetOption51 #6969

meingraham opened this issue Nov 19, 2019 · 4 comments
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended

Comments

@meingraham
Copy link
Collaborator

meingraham commented Nov 19, 2019

Have you looked for this feature in other issues and in the wiki?
Yes

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
As of this commit, Tasmota is able to query for the type of ESP chip in the device via GetDeviceHardware(). Currently, SetOption51 allows a user to "expose" GPIO9 and GPIO10 as available pins. This is provided since the ESP8285 frees these pins up. However, the option does not prevent a user for enabling SetOption51 if they have an ESP8266. Now that Tasmota is able to know the type of chip, it ought to prevent a user from enabling this feature if the device uses an ESP8266.

Describe alternatives you've considered

  • Leave as is and let users do something they shouldn't.
  • Get rid of SetOption51 altogether and just "manage" GPIO9 and GPIO10 automatically.
@ascillato2 ascillato2 added the enhancement Type - Enhancement that will be worked on label Nov 19, 2019
@arendst
Copy link
Owner

arendst commented Nov 20, 2019

Mike, you're too quick. I noticed some devices do not report the correct chip. Needs more time before abandoning SO51.

@meingraham
Copy link
Collaborator Author

Noted. Archive the request for now then.

Thanks

Mike

P.S.

Mike, you're too quick.

Hmmm, my wife said something similar the other night ;-)

@ascillato2
Copy link
Collaborator

Archive the request for now then.

Ok. Let's reopen this issue if we can add this automatic selection.

@ascillato2 ascillato2 added the requested feature (hold over) Result - Feature that will not be added soon (out of scope) label Nov 21, 2019
arendst added a commit that referenced this issue Nov 21, 2019
Add hardware detection to be overruled with SetOption51 (#6969)
@arendst arendst added the fixed Result - The work on the issue has ended label Nov 21, 2019
@arendst
Copy link
Owner

arendst commented Nov 21, 2019

It now automaticcaly selects the correct functionality based on hardware. User can still overrule wit SO51 1

@ascillato2 ascillato2 removed the requested feature (hold over) Result - Feature that will not be added soon (out of scope) label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Development

No branches or pull requests

3 participants