Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for another variant of the 6-digit TM1637 display module #11422

Closed
wants to merge 1 commit into from
Closed

Added support for another variant of the 6-digit TM1637 display module #11422

wants to merge 1 commit into from

Conversation

ajithvasudevan
Copy link

@ajithvasudevan ajithvasudevan commented Mar 22, 2021

Description:

This adds support for another variant of the 6-digit TM1637 display module, where the digit order is different in hardware.
Also, this fixes the issue reported here #11358 (comment)

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Mar 22, 2021

Thx.

I see what you need but I don't like it.

The issue is that both the ILI driver and your driver seem to need additional submodel parameterization. That's fine but adding another command to do this doesn't make sense regarding keeping the code small.

I will rewrite your PR by using a new command for both ILI and your driver.

Stay tuned...

arendst added a commit that referenced this pull request Mar 22, 2021
Add support for another variant of the 6-digit TM1637 display module selected by command ``DisplayType 1`` (#11422)
@arendst
Copy link
Owner

arendst commented Mar 22, 2021

Merged using command DisplayType 1 for the second variant.

@arendst arendst closed this Mar 22, 2021
@ajithvasudevan
Copy link
Author

Merged using command DisplayType 1 for the second variant.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants