Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSend http PUT with JSON payload #12249

Closed
wants to merge 5 commits into from

Conversation

cjstephan
Copy link

Description:

WebSend may now use http PUT for starting my vacuum cleaner.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Sorry, I did not found out how to run CI tests. Is Github doing this automatically on push event?
This is my first try of a pull request so please be lenient.

@s-hadinger
Copy link
Collaborator

Thanks. I'm not a big fan of changing the hostname to indicate a PUT. I'm surprised your vacuum cleaner needs a PUT rather than a POST. Unless we come with a more generic version, this looks very specific to your use case.

@github-actions
Copy link

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Jun 25, 2021
@github-actions
Copy link

This PR was automatically closed because of being stale.

@github-actions github-actions bot closed this Jun 30, 2021
@JVital2013 JVital2013 mentioned this pull request Sep 24, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Action - Issue left behind - Used by the BOT to call for attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants