Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in IRHVAC #19389

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Fix crash in IRHVAC #19389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file.
### Fixed
- Shutter invert (#19341, #19374)
- Teleinfo power (#19381)
- Fix crash in IRHVAC

### Removed

Expand Down
2 changes: 1 addition & 1 deletion tasmota/include/i18n.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
#define D_JSON_MODEL "Model"
#define D_JSON_MOISTURE "Moisture"
#define D_JSON_MQTT_COUNT "MqttCount"
#define D_JSON_NA "n/a"
#define D_JSON_NULL "null"
#define D_JSON_NO "No"
#define D_JSON_NOISE "Noise"
#define D_JSON_NONE "None"
Expand Down
2 changes: 1 addition & 1 deletion tasmota/tasmota_xdrv_driver/xdrv_05_irremote_full.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ namespace {
void addFloatToJson(JsonGeneratorObject& json, const char* key, float value, float noValueConstant = NAN) {
if (!isnan(noValueConstant) && value == noValueConstant) {
//The "no sensor value" may not be straightforward (e.g.-100.0), hence replacing with explicit n/a
json.add(key, PSTR(D_JSON_NA));
json.addStrRaw(key, PSTR(D_JSON_NULL));
return;
}
char s[6]; // Range: -99.9 <> 999.9 should be fine for any sensible temperature value :)
Expand Down