Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2s audio, some small improvements #21433

Merged
merged 1 commit into from
May 18, 2024
Merged

i2s audio, some small improvements #21433

merged 1 commit into from
May 18, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented May 18, 2024

Description:

  1. Prevents unworkable default mode PDM for microphone on SOC's that do not support PDM mode (e.g. ESP-S2).
  2. Prevents crash when attempting to record in stereo mode, which does not really make sense on a mono microphone, but at least it is possible now.
  3. Less strict memory management for the MP3 encoder, which does not need preallocation anymore in the driver settings. Now late allocation is supported, but preallocation is still possible and it can be still useful, if free (large blocks of) heap is not guaranteed later in the running system.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 0e5b2a8 into arendst:development May 18, 2024
59 checks passed
@Staars Staars deleted the i2s branch May 19, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants