Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HASPmota delete instead of delete() #22245

Merged
merged 1 commit into from
Oct 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
- HASPmota `cpicker` and `msgbox`

### Breaking Changed
- HASPmota `delete` instead of `delete()`

### Changed
- ESP32 platform update from 2024.09.10 to 2024.09.30 and Framework (Arduino Core) from v3.0.5 to v3.1.0.240926 (#22203)
Expand Down
16 changes: 8 additions & 8 deletions lib/libesp32_lvgl/lv_haspmota/src/embedded/lv_haspmota.be
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ class lvh_root
raise "type_error", "you cannot assign to 'delete'"
end
def get_delete()
self.delete()
self._delete()
end
def delete()
def _delete()
# to be overriden
end

Expand Down Expand Up @@ -658,10 +658,10 @@ class lvh_obj : lvh_root
end

#====================================================================
# `delete` special attribute used to delete the object
# `_delete` special attribute used to delete the object
#====================================================================
# the actual delete method, overriden
def delete()
# the actual _delete method, overriden
def _delete()
# remove any rule
self.remove_val_rule()
self.remove_text_rule()
Expand Down Expand Up @@ -1858,10 +1858,10 @@ class lvh_scale_section : lvh_root
end

#====================================================================
# `delete` special attribute used to delete the object
# `_delete` special attribute used to delete the object
#====================================================================
# the actual delete method, overriden
def delete()
# the actual _delete method, overriden
def _delete()
self._style.del()
self._style = nil
self._style10.del()
Expand Down
Loading