Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented automatic setting of clock display from network time. #6034

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

adebeun
Copy link
Contributor

@adebeun adebeun commented Jul 7, 2019

Description:

The display of the AZ7798 CO2 meter includes a clock showing date and time.This is normally set manually but slowly drifts or is reset when the power is off for too long. This enhancement automatically sets the clock time from the network time, shortly after power on and then every 24 hours thereafter.

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched (Also remember to add to changelog.ino file without updating version)
  • Only one feature/fix was added per PR.
  • The code change is tested and works.
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@ascillato
Copy link
Contributor

Hi,

Please complete the checklist. Thanks

Copy link
Owner

@arendst arendst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove changes from _changelog.ino as it interferes with current file.

@arendst arendst merged commit 27ac431 into arendst:development Jul 8, 2019
@adebeun
Copy link
Contributor Author

adebeun commented Jul 8, 2019

You checklist confused me. The second item includes "(Also remember to add to changelog.ino file without updating version)". What do you mean by that?

@arendst
Copy link
Owner

arendst commented Jul 8, 2019

I know. I'll remove it as I want PR's to be as small as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants