Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send IRSend for Pioneer devices (#6100) #6119

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

s-hadinger
Copy link
Collaborator

Description:

After spending the ween-end to remote debug the issue from #6100 and with the help of @Oprtyo

It appears that Pioneer timings are 5% shorter than NEC. If you're lucky, some devices will tolerate the difference, but some will not. This fixes aligns timing to actual Pioneer IR. For example, the NEC preamble is 9ms + 4.5ms, whereas the Pioneer timing is 8.5ms and 4.25ms. Frequency is also 40KHz instead of 38KHz.

I also introduced an easier way to add IR codes above SHARP (14). Pioneer code is 50 in IRRemoteESP8266, which would require very long strings.

The feature depends on the #define USE_IR_SEND_PIONEER toggle that I enabled by default. @arendst you decide whether you accept to keep it enabled (there are lots of Pioneer devices out there) or if it requires custom compile.

Note: I will make a PR for IRRemoteESP8266 to make it hopefully official.

Code increase: 240 bytes.

Related issue (if applicable): fixes #6100

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2 and 2.5.2
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 762ec9d into arendst:development Jul 22, 2019
@s-hadinger s-hadinger deleted the fix_6100 branch July 23, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irsend doesn't work for pioneer
2 participants