Fix send IRSend for Pioneer devices (#6100) #6119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After spending the ween-end to remote debug the issue from #6100 and with the help of @Oprtyo
It appears that Pioneer timings are 5% shorter than NEC. If you're lucky, some devices will tolerate the difference, but some will not. This fixes aligns timing to actual Pioneer IR. For example, the NEC preamble is 9ms + 4.5ms, whereas the Pioneer timing is 8.5ms and 4.25ms. Frequency is also 40KHz instead of 38KHz.
I also introduced an easier way to add IR codes above SHARP (14). Pioneer code is 50 in IRRemoteESP8266, which would require very long strings.
The feature depends on the
#define USE_IR_SEND_PIONEER
toggle that I enabled by default. @arendst you decide whether you accept to keep it enabled (there are lots of Pioneer devices out there) or if it requires custom compile.Note: I will make a PR for IRRemoteESP8266 to make it hopefully official.
Code increase: 240 bytes.
Related issue (if applicable): fixes #6100
Checklist: