Solax X1: Code refactor and optimization, add as energy driver to get… #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… today/yesterday totals and P1 smart meter function
|
@arendst, If you are agree, we can delete the previous sensor "xsns_49_solaxX1.ino" and leave the new one "xnrg_12_solaxX1.ino", I have been testing the new code along one week without issues. What do you think? |
|
If all functionality is moved to xnrg_12 I agree to drop the old driver. I also would love to drop the old sdm120 and sdm630 drivers. |
arendst
added a commit
that referenced
this pull request
Oct 18, 2019
* Replace obsolete xsns_23_sdm120 with xnrg_08_sdm120 and consolidate define USE_SDM120 * Replace obsolete xsns_25_sdm630 with xnrg_10_sdm630 and consolidate define USE_SDM630 * Replace obsolete xsns_49_solaxX1 with xnrg_12_solaxX1 (#6677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… today/yesterday totals, P1 smart meter function and minor issue fix.
Description:
I add a new version to use the energy sensors code, and now can get today/yesterday totals, P1 smart sensor function.
Code optimization and fix minor issue.
Related issue (if applicable): fixes #
Checklist: