Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change new Fade system much smoother, Speed now up to 40 #7007

Merged
merged 1 commit into from
Nov 23, 2019

Conversation

s-hadinger
Copy link
Collaborator

Description:

Major rewrite of the Fade system for a much smoother rendering.

Now Speed is deterministic and represents the time in half-seconds to move from 0% to 100%.

Example: Speed 4 means it takes 2 seconds from 0% to 100%, and by consequence 0.5s from 0% to 25%.

Other changes:

  • Fixed bug that prevented RGB values to go above 25% of brightness (after Gamma correction) if White Blend mode was activated
  • changeUIntScale() can now accepts to_min > to_max and compute accurately. This reduces overall code size.

Flash increase: 350 bytes.

Related issue (if applicable): fixes #6942 #3714

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6.1
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 32ab18b into arendst:development Nov 23, 2019
@s-hadinger s-hadinger mentioned this pull request Nov 24, 2019
6 tasks
@s-hadinger s-hadinger deleted the fade_new branch November 26, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB PWM Dimmer Steps - improvement in softness for lowlight situations
2 participants