Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PWM flickering during wifi connection (#8046) #8094

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

s-hadinger
Copy link
Collaborator

Description:

Fix #7851 allowed the PWM interrupt handler to keep phases constant between channels and avoid flickering.

Unfortunatel, under heavy interrupt load, at wifi connection, the interrupt handler struggles to keep PWM at correct levels. In case of an overshoot of the PWM cycle by more than 25%, the interrupt handler reverts to the previous behavior and favors PWM level instead of phases.
This minimizes flickering at wifi connection.

Related issue (if applicable): fixes #8046

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core Tasmota_core_stage
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 8d97bcd into arendst:development Apr 8, 2020
@s-hadinger s-hadinger deleted the pwm_flicker2 branch January 6, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BW-LT20 blinks when turned on
2 participants