Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUE fixes and HSB support #89

Closed
wants to merge 34 commits into from
Closed

HUE fixes and HSB support #89

wants to merge 34 commits into from

Conversation

altelch
Copy link
Contributor

@altelch altelch commented Feb 20, 2017

Hi,

fixed an error in JSON argument evaluation what caused wrong setting changes. Implemented full HSB support for HUE api calls (colormode hs).

Greetings,

Heiko.

altelch and others added 30 commits January 29, 2017 11:06
…ay. If sleep == 0 then delay == yield. Else delay(x) is delay and yield.
Conflicts:
	sonoff/sonoff.ino
	sonoff/xdrv_ws2812.ino
Conflicts:
	sonoff/webserver.ino
	sonoff/xdrv_wemohue.ino
…or future enhancemends in HUE and IR send function. Initial code for IR send support via MQTT using IRremoteESP8266.
Conflicts:
	sonoff/sonoff.ino
	sonoff/sonoff_template.h
	sonoff/webserver.ino
	sonoff/xdrv_ir_send.ino
@altelch
Copy link
Contributor Author

altelch commented Feb 20, 2017

Bwah, now travis-ci uses another IRremoteESP8266 than what is included in Arduino!? Doesn't matter for the HUE part.

@altelch
Copy link
Contributor Author

altelch commented Feb 20, 2017

Ok, changed platformio.ini:
lib_deps = PubSubClient@~2.6, NeoPixelBus@~2.2.6, https://github.com/sebastienwa
rin/IRremoteESP8266.git, ArduinoJSON@~5.8.3

Now the correct versions are used and the built works again.

@arendst
Copy link
Owner

arendst commented Feb 21, 2017

First looked at your the PlatformIO library suggestion. If I try it locally it fails as it needs git installed to download and install IRremoteESP8266.git so I decided to add all libraries to the repository in the lib folder.

Now platformIO works great both locally and on Travis using the supplied libs.

I still need to look at your Hue changes but have to find some time for it...

arendst added a commit that referenced this pull request Feb 21, 2017
3.9.20 20170221
* Add minimal basic authentication to Web Admin mode (#87)
* Fix Hue and add HSB support (#89)
@arendst
Copy link
Owner

arendst commented Feb 21, 2017

Implemented in version 3.9.20 just released

@arendst arendst closed this Feb 21, 2017
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 6, 2018
3.9.20 20170221
* Add minimal basic authentication to Web Admin mode (arendst#87)
* Fix Hue and add HSB support (arendst#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants