Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rules that override button holds #9986

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Support rules that override button holds #9986

merged 1 commit into from
Nov 26, 2020

Conversation

pcdiem
Copy link
Contributor

@pcdiem pcdiem commented Nov 26, 2020

Description:

Add support for rules that override button holds. Because the hold time of buttons in PWM Dimmer is different than the SetOption32 value, button hold are processed outside the normal Tasmota button processing. This PR adds support for checking to see if a rule is active that would override a button hold. If there is, the button hold is not processed by PWM Dimmer.

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.7
  • The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants