Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

[TASK] Migrate /api/me endpoin to /api/v1/me #139

Closed
Tracked by #4773
jfcalvo opened this issue May 6, 2024 · 0 comments · Fixed by #140
Closed
Tracked by #4773

[TASK] Migrate /api/me endpoin to /api/v1/me #139

jfcalvo opened this issue May 6, 2024 · 0 comments · Fixed by #140
Assignees

Comments

@jfcalvo
Copy link
Member

jfcalvo commented May 6, 2024

No description provided.

@jfcalvo jfcalvo self-assigned this May 6, 2024
@jfcalvo jfcalvo transferred this issue from argilla-io/argilla May 6, 2024
@jfcalvo jfcalvo changed the title [TASK] Migrate /me/ endpoin to /api/v1/me [TASK] Migrate /me endpoin to /api/v1/me May 6, 2024
@jfcalvo jfcalvo linked a pull request May 6, 2024 that will close this issue
15 tasks
@jfcalvo jfcalvo changed the title [TASK] Migrate /me endpoin to /api/v1/me [TASK] Migrate /api/me endpoin to /api/v1/me May 7, 2024
jfcalvo added a commit that referenced this issue May 7, 2024
# Description

This PR creates a new `/api/v1/me` endpoint with similar functionality
to the old `/me` endpoint from API v0.

The following changes are included:
* `full_name` user attribute is not used in the new `User` v1 schema.
Instead the frontend should concatenate `first_name` and `last_name` if
necessary.
* `workspaces` user attribute is not used in the new `User` v1 schema.
`/api/v1/me/workspaces` could be used instead.

Closes #139

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Adding new tests.

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@jfcalvo jfcalvo closed this as completed May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant