This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
[TASK] Add new validator classes for Questions #73
Assignees
Comments
|
Hey @jfcalvo! Great to see you back here stirring the pot with more ideas. 😄 I'm already on it and will get back to you with a full answer shortly. |
15 tasks
jfcalvo
added a commit
that referenced
this issue
Mar 19, 2024
# Description This PR is a refactor moving all the validations for question to new validator classes: `QuestionCreateValidator`, `QuestionUpdateValidator` and `QuestionDeleteValidator`. I have added some small tests too covering stuff that was not covered previously to validate update questions. I will add missing `visible_options` validations in a new PR. Closes #73 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] Test suite should be passing. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: