Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

feat: update span questions #50

Merged

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Mar 5, 2024

Description

This PR add changes so span questions can be updated and labels on settings reorder. The labels can not be changed only reordered as we are already doing for label and multi label questions.

Closes #49

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon March 5, 2024 12:06
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (c7262d1) to head (3ba63d0).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/create-span-question-responses      #50   +/-   ##
====================================================================
  Coverage                                90.31%   90.31%           
====================================================================
  Files                                      188      188           
  Lines                                     9269     9274    +5     
====================================================================
+ Hits                                      8371     8376    +5     
  Misses                                     898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit 975ca82 into feat/create-span-question-responses Mar 5, 2024
13 checks passed
@jfcalvo jfcalvo deleted the feat/update-span-questions branch March 5, 2024 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants