Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

feat: add visible options parameter for span questions #63

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 11, 2024

Description

This PR adds support for visible_options parameter for span question settings.

Also, the question settings schemas have been grouped by type, so is more easy to compare changes between create an update operations.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Also, the settings classes have been grouped by question types.
This change simplifies to see differences between models when create/update and get
…io/argilla-server into feat/support-for-span-questions
@frascuchon frascuchon requested a review from jfcalvo March 11, 2024 14:44
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (47be7ad) to head (cd91636).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           feat/support-for-span-questions      #63      +/-   ##
===================================================================
+ Coverage                            90.33%   90.34%   +0.01%     
===================================================================
  Files                                  189      189              
  Lines                                 9292     9302      +10     
===================================================================
+ Hits                                  8394     8404      +10     
  Misses                                 898      898              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon requested a review from jfcalvo March 11, 2024 17:38
@frascuchon frascuchon merged commit 7f1a5fc into feat/support-for-span-questions Mar 12, 2024
13 checks passed
@frascuchon frascuchon deleted the feat/add-visible_options-parameter-for-span-questions branch March 12, 2024 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants