This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add question update visible options validation #76
Merged
jfcalvo
merged 26 commits into
refactor/response-and-suggestion-refactors
from
feat/add-question-update-visible-options-validation
Mar 19, 2024
Merged
feat: add question update visible options validation #76
jfcalvo
merged 26 commits into
refactor/response-and-suggestion-refactors
from
feat/add-question-update-visible-options-validation
Mar 19, 2024
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or/improve-responses-and-suggestions-api-schemas
…tion_create.value
… into refactor/add-response-create-validator
…or/improve-responses-and-suggestions-api-schemas
… into refactor/add-response-create-validator
…dd-response-update-upsert-validators
… into refactor/add-response-create-validator
…dd-response-update-upsert-validators
…move questions models file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/response-and-suggestion-refactors #76 +/- ##
==============================================================================
+ Coverage 90.44% 90.45% +0.01%
==============================================================================
Files 191 191
Lines 9406 9416 +10
==============================================================================
+ Hits 8507 8517 +10
Misses 899 899 ☔ View full report in Codecov by Sentry. |
frascuchon
approved these changes
Mar 18, 2024
Base automatically changed from
refactor/add-question-validators
to
refactor/response-and-suggestion-refactors
March 19, 2024 10:50
…dd-question-update-visible-options-validation
jfcalvo
merged commit Mar 19, 2024
db96020
into
refactor/response-and-suggestion-refactors
13 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a new validation to
QuestionUpdateValidator
class so we are now validatingvisible_options
attribute when it's updated.The validation will avoid that the number specified for
visible_options
is bigger than the number of available options defined by the question.Closes #75
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist