Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

fix: publish of argilla-server Python package to PyPI using wrong Python version #9

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jan 26, 2024

Description

Looks like a bug on setup-pdm action was not correctly reading the Python version from pyproject.toml and causing to use the default version from ubuntu-latest container (v3.12 for this case).

Upgrading from pdm-project/setup-pdm@v3 to pdm-project/setup-pdm@v4 looks like fixing the issue.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

  • Python package should be correctly build and pushed to PyPI

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo changed the title fix: use pdm-project/setup-pdm@v4 fix: some GitHub workflows using incorrect version of Python Jan 26, 2024
@jfcalvo jfcalvo changed the title fix: some GitHub workflows using incorrect version of Python fix: publish of argilla-server Python package to PyPI Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dabc0a) 91.71% compared to head (705f470) 91.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         170      170           
  Lines        8651     8651           
=======================================
  Hits         7934     7934           
  Misses        717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo changed the title fix: publish of argilla-server Python package to PyPI fix: publish of argilla-server Python package to PyPI using wrong Python version Jan 26, 2024
@jfcalvo jfcalvo merged commit 91a57f4 into main Jan 26, 2024
13 checks passed
@jfcalvo jfcalvo deleted the fix/publish-package-wrong-python-version branch January 26, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant