-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Allow configure overlapping support #4694
Labels
area: architecture
Indicates that an issue or pull request is related to the architecture
severity: minor
Indicates that the issue isn't urgent or blocking
team: backend
Indicates that the issue or pull request is owned by the backend team
type: enhancement
Indicates new feature requests
Comments
This was referenced Apr 3, 2024
dosubot
bot
added
area: architecture
Indicates that an issue or pull request is related to the architecture
severity: minor
Indicates that the issue isn't urgent or blocking
team: backend
Indicates that the issue or pull request is owned by the backend team
type: enhancement
Indicates new feature requests
labels
Apr 3, 2024
13 tasks
frascuchon
added a commit
to argilla-io/argilla-server
that referenced
this issue
Apr 4, 2024
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR adds support for configure overlapping for span questions on creation and update. Refs argilla-io/argilla#4694 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor (change restructuring the codebase without changing functionality) - [X] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: José Francisco Calvo <jose@argilla.io>
frascuchon
added a commit
that referenced
this issue
Apr 8, 2024
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR adds the `allow_overlapping` field for span questions to configure span questions with overlapping support. The default value is set to `False` to align the previous version of the span question. It must be merged after argilla-io/argilla-server#89 ```python span_question = rg.SpanQuestion(name="spans", .., allow_overlapping=True) ... ``` Closes #4694 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor (change restructuring the codebase without changing functionality) - [X] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: burtenshaw <ben@argilla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: architecture
Indicates that an issue or pull request is related to the architecture
severity: minor
Indicates that the issue isn't urgent or blocking
team: backend
Indicates that the issue or pull request is owned by the backend team
type: enhancement
Indicates new feature requests
No description provided.
The text was updated successfully, but these errors were encountered: