Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG-UI/UX] Cannot share dataset URLs after user signin on HF spaces #5633

Closed
frascuchon opened this issue Oct 28, 2024 · 0 comments · Fixed by #5635
Closed

[BUG-UI/UX] Cannot share dataset URLs after user signin on HF spaces #5633

frascuchon opened this issue Oct 28, 2024 · 0 comments · Fixed by #5635
Assignees
@damianpumar @leiyre
Milestone
v2.4.1

Comments

@frascuchon
Copy link
Member

Describe the bug

When running the Argilla server in the HF spaces, sharing URLs with users needing an authentication flow does not work. After the user is authenticated, they are redirected to the home page instead of reaching the shared URL. This is working when running the Argilla server using the server docker image.

To Reproduce

The URL https://argilla-argilla-template-space.hf.space/dataset/3349bf8d-0755-403c-9964-a2e30544b97a/annotation-mode should be shown after sign-in

Expected behavior

Screenshots

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Argilla Version [e.g. 1.0.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. argilla:v1.0.0]:

Additional context
@frascuchon frascuchon added this to the v2.4.0 milestone Oct 28, 2024
@frascuchon frascuchon mentioned this issue Oct 28, 2024
Merged
@frascuchon frascuchon modified the milestones: v2.4.0, v2.5.0 Oct 29, 2024
@frascuchon frascuchon mentioned this issue Oct 31, 2024
Open
@frascuchon frascuchon modified the milestones: v2.5.0, v2.4.1 Nov 6, 2024
frascuchon added a commit that referenced this issue Nov 6, 2024
@frascuchon @jfcalvo @pre-commit-ci
[BUGFIX] argilla frontend: redirect after login (#5635)
229809e 
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

Closes #5633

**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: José Francisco Calvo <jose@argilla.io>
Co-authored-by: José Francisco Calvo <josefranciscocalvo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
frascuchon added a commit that referenced this issue Nov 8, 2024
@frascuchon @jfcalvo @pre-commit-ci
[BUGFIX] argilla frontend: redirect after login (#5635)
0fcce0a 
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

Closes #5633

**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: José Francisco Calvo <jose@argilla.io>
Co-authored-by: José Francisco Calvo <josefranciscocalvo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damianpumar damianpumar

@leiyre leiyre

Labels
None yet
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging a pull request may close this issue.

[BUGFIX] argilla frontend: redirect after login argilla-io/argilla
3 participants
@frascuchon @damianpumar @leiyre