Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFIG] argilla: Add Python 3.13 support #5652

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

frascuchon
Copy link
Member

Description

Closes #5627

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the title [CONFIG] argilla Add Python 3.13 support [CONFIG] argilla: Add Python 3.13 support Oct 30, 2024
@frascuchon frascuchon changed the title [CONFIG] argilla: Add Python 3.13 support [WIP] [CONFIG] argilla: Add Python 3.13 support Oct 30, 2024
@frascuchon
Copy link
Member Author

Problems using python 3.13 + pyarrow apache/arrow#44443

@oulianov
Copy link

oulianov commented Oct 30, 2024

The dependencies install pyarrow 17.0.0, but python 3.13 is only supported for pyarrow 18.0.0 (released 2 days ago)
apache/arrow#43519

@oulianov
Copy link

I ran pdm lock with the latest pdm version using your pyproject.toml file. The solver gave me the right version of pyarrow (18.0).

Capture d’écran 2024-10-30 à 17 33 18

So my guess is you just need to run pdm lock again and tests will pass for 3.13 :)

Let me know how it goes.

@frascuchon
Copy link
Member Author

frascuchon commented Oct 31, 2024

Thanks for the tip @oulianov. The pdm lock will update other dependencies making the whole workflow fails.

I defined the 18.0.0 as a dev dependency and everything is working.

@burtenshaw I think this is ready to merge.

@frascuchon frascuchon changed the title [WIP] [CONFIG] argilla: Add Python 3.13 support [CONFIG] argilla: Add Python 3.13 support Oct 31, 2024
@frascuchon frascuchon added this to the v2.5.0 milestone Nov 5, 2024
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge it.

@frascuchon frascuchon merged commit 02df3d1 into develop Nov 6, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the chore/argilla/python3.13-support branch November 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Python 3.13 support
3 participants