This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
Activate warnings #547
Merged
Activate warnings #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool!
El vie., 16 abr. 2021 10:30, David Fidalgo ***@***.***>
escribió:
… Merged #547 <#547> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#547 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIOJJ2UZAT74UH2EBDY4NDTI7YSHANCNFSM43ALKWRQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we deactivated all warnings, i think to avoid too many warnings from allennlp. Here i reactivate them again, since we are moving away from the allennlp trainer and i think they can be useful to spot some potential issues with the usage of third party libraries. When we encounter a frequent warning we should try to fix it or specifically deactivate that warning somehow.
This PR also includes some fixes that avoid warnings and their potential issues.