-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llm generate upgrade #1034
Open
plaguss
wants to merge
34
commits into
develop
Choose a base branch
from
llm-generate-upgrade
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Llm generate upgrade #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1034/ |
CodSpeed Performance ReportMerging #1034 will not alter performanceComparing Summary
|
…dd new merge_dicts to help merging user-assistant messages in magpie
…to llm-generate-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the output from
llm.generate
to make it more feature rich.Previously we only returned the generated text:
Now it is updated to allow for statistics related to the generation:
This PR only includes
input_tokens
andoutput_tokens
as statistics, but we can add as much as needed in the future.This information is moved to
distilabel_metadata
in the following way, to avoid collisions between statistics of different steps:NOTE:
Most
Task
reuse the sameTask.process
method to process the generations, and nothing else has to be done, but for tasks likeMagpie
where theprocess
method is overwritten, this has to be updated.Closes #738