docs: improve docs for MinHashDedup
Step
#1050
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
While looking at this nice feature, I noticed some errors in the docstring and I'm trying to fix them.
Slightly related feedback
Initially I was bit surprised that I cannot easily understand why a single text element is considered a duplicate when using this technique, while this is transparent using
EmbeddingGeneration
+EmbeddingDedup
.But I understand that this technique is more complex, even from the implementation point of view...
@gabrielmbmb @plaguss