Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import Error for KeepColumns in instruction_backtranslation.md (Issue #785) #786

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

Hassaan-Qaisar
Copy link
Contributor

This PR addresses issue #785, which involved a missing import (KeepColumns) in the pipeline definition. The KeepColumns class was referenced but not imported, causing a NameError during execution.

@plaguss plaguss added the documentation Improvements or additions to documentation label Jul 18, 2024
@plaguss plaguss added this to the 1.3.0 milestone Jul 18, 2024
@plaguss plaguss linked an issue Jul 18, 2024 that may be closed by this pull request
@plaguss plaguss self-requested a review July 18, 2024 06:43
Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #786 will not alter performance

Comparing Hassaan-Qaisar:main (8313988) with main (a22c7e2)

Summary

✅ 1 untouched benchmarks

Copy link
Contributor

@plaguss plaguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Hassaan-Qaisar!

@plaguss plaguss merged commit e95f9ea into argilla-io:main Jul 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Missing Import for KeepColumns in Instruction Backtranslation
2 participants