Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create file per hostname in CudaDevicePlacementMixin #814

Merged
merged 9 commits into from
Jul 27, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

In some environments, all the nodes of the cluster shares the same file system, so they were using the same file to check which GPUs were being used. This is incorrect, as the GPUs IDs has to be checked per node, so now a new file is created per hostname.

@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Jul 23, 2024
@gabrielmbmb gabrielmbmb requested a review from plaguss July 23, 2024 14:54
@gabrielmbmb gabrielmbmb self-assigned this Jul 23, 2024
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-814/

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #814 will not alter performance

Comparing cuda-device-placement-mixin-file-per-host (7bee86c) with develop (04b86f5)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb force-pushed the cuda-device-placement-mixin-file-per-host branch from 76c38f1 to 7bee86c Compare July 27, 2024 18:30
@gabrielmbmb gabrielmbmb merged commit 25601bb into develop Jul 27, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the cuda-device-placement-mixin-file-per-host branch July 27, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant