Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save_artifact method to _Step #871

Merged
merged 11 commits into from
Aug 14, 2024
Merged

Add save_artifact method to _Step #871

merged 11 commits into from
Aug 14, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

This PR adds a new method called save_artifact to the _Step base class that allows saving artifacts generated by an Step such as the Faiss index generated by FaissNearestNeighbour step. The generated artifacts will be uploaded to the Hugging Face Hub when using the push_to_hub method of the Distiset class.

Closes #834

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Aug 8, 2024
@gabrielmbmb gabrielmbmb added this to the 1.4.0 milestone Aug 8, 2024
@gabrielmbmb gabrielmbmb self-assigned this Aug 8, 2024
@gabrielmbmb gabrielmbmb linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 8, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-871/

@gabrielmbmb gabrielmbmb marked this pull request as ready for review August 9, 2024 15:38
Copy link
Contributor

@plaguss plaguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Maybe we should add docs for this

src/distilabel/distiset.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Aug 14, 2024

CodSpeed Performance Report

Merging #871 will not alter performance

Comparing step-artifacts (28b8160) with develop (f382f1c)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb merged commit c8df5a9 into develop Aug 14, 2024
6 of 7 checks passed
@gabrielmbmb gabrielmbmb deleted the step-artifacts branch August 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow Steps to produce artifacts
2 participants