Fix progress when using VAD chunking #179
Conversation
finnvoor
force-pushed
the
main
branch
2 times, most recently
from
331cf70
to
8a1baa7
Compare
|
This looks great, can you explain how the progress will look in the UI? In other words, on what event does the percentage increase? Maybe a video recording would help if you are able. My current understanding is that each child's progress will be tracked independently and messaged back to the parent the total progress of each window—is that correct? |
|
The progress update happens at the same time still, after each mel>encode>decode loop, but previously each transcribe task would go from 0->1 simultaneously, resulting in random updates. Now each task is a child progress of the total progress, with an equal weighting, so the progress increases properly as each child progress goes from 0->1. BeforeAfter |
|
For some reason watchos is timing out, could you try the simulator tests for watchos? I will update the timeout if those succeed locally |
|
Not having any issues with the tests locally, the same test command passes. Not sure what the issue is with the CI. |
|
The macos 13 xlarge tests passed so I think this is good to go. Just needs a higher timeout for the smaller runner. |
|
Ok the errors are due to the simulator not booting fast enough, will update with a fix in a follow up PR that resolves #100 Thanks for this submission! This will make the progress hard to estimate full time to complete because it will depend on the window size in the VAD chunks, but it is a great workaround in the meantime 🎉 |
|
FYI just merged this #180 there seems to be an issue with the combine stuff on watchOS, so I limited the test to not run on that platform. Not sure whats causing it but its only happening on macOS 14 runners with low compute resources. |
* commit 'c93d613c8c6fc3ec5b9d1d9da5d1f4206183c5e4': Fix language logits filter Fix functional tests thread issue Fix resampling large files (argmaxinc#183) Fix indeterminate tests (argmaxinc#180) Fix progress when using VAD chunking (argmaxinc#179) Update unit-test.yml timeout # Conflicts: # Sources/WhisperKit/Core/AudioProcessor.swift
Previously progress would jump around as the same progress object was used for every chunk. Now every chunk is added as a child progress with equal unit count.
fixes #151