skip functional tests for models that are not downloaded. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_whisper-tiny and openai_whisper-large-v3 are downloaded.
|
Moved the typo fix to its own branch (for a future PR). |
|
It failed when building for VisionOS, which I don't have as a platform locally. |
|
@metropol whatever is more convenient for you, probably just reverting the commit that removes it would be simplest. |
This reverts commit 34e26bc.
|
@ZachNagengast I've reverted the commit the removes the typo. |
finnvoor
pushed a commit
to finnvoor/WhisperKit
that referenced
this pull request
Mar 13, 2024
* skip tests for models that are not downloaded, but assume that openai_whisper-tiny and openai_whisper-large-v3 are downloaded. * fix typo. * Revert to before the typo fix * Revert "Revert to before the typo fix" This reverts commit 34e26bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi all, it seems that functional tests require two models to be downloaded: openai_whisper-tiny (because of
testRealTimeFactorTiny()) and openai_whisper-large-v3 (because oftestInitLarge()andtestRealTimeFactorLarge()). This should probably be added to the CONTRIBUTING.md, however this PR does not make this change.Another functional test,
testOutputAll()- actuallyallModelPaths(), assumes that folders in./Models/whisperkit-coreml, which are created from themake setup-model-repo, contain actual models, while in fact only models explicitly downloaded withmake download-model MODEL=xormake download-modelsare present.testOutputAll()fails if not all models have been downloaded, which is not ideal. Running all tests for all models (takes a long time and) makes sense in some scenarios, but probably not to test some code changes.I've implemented some changes so that
allModelPaths()only returns folders that contain downloaded models. This is done by checking if a proxy file (MelSpectrogram.mlmodelc/coremldata.bin) is a git lfs pointer file (starting withversion https://…). If it is, then the folder is not included.