-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WhisperKit CLI cleanup #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking in general with the cleanup, however this will break quite a bit of our benchmark/eval code as is, because it calls this function from python as a shell command, and would require updating all of that as well. If this is a blocker for the homebrew PR then we should discuss further, otherwise it would be ideal to keep the interfaces the same.
Sounds fair. I could potentially add a PR in https://github.com/argmaxinc/whisperkittools repo to accommodate for these changes but I understand the concern. I reverted the renaming part, please take a 2nd look @ZachNagengast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, will merge once tests pass 💯
Before taking on #36 I decided to do a little cleanup in the CLI
WhisperKitArguments
structtranscribe
subcommandwhisper-kit
so rn in order to run the transcribe command the user has to type
swift run whisper-kit transcribe
It's going to be convenient if we're going to add more subcommands in future (e.g.
swift run whisper-kit translate
)