Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instead of using direct methods using enter and exit. #54

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

hariharan-devarajan
Copy link
Collaborator

@hariharan-devarajan hariharan-devarajan commented Mar 21, 2023

Instead of

        global profile_args
        profile_args["epoch"] = epoch_number
        t0 = time()
        super().__init__(format_type, dataset_type, epoch_number)
        self._dataset = None
        t1 = time()
        PerfTrace.get_instance().event_complete(f"{self.__init__.__qualname__}", MY_MODULE, t0, t1 - t0,
                                                arguments=profile_args)

We do just this

        with Profile(name=f"{self.__init__.__qualname__}", cat=MODULE_DATA_LOADER, epoch=epoch_number):
            super().__init__(format_type, dataset_type, epoch_number)
            self._dataset = None

@hariharan-devarajan hariharan-devarajan self-assigned this Mar 21, 2023
@hariharan-devarajan hariharan-devarajan added the enhancement New feature or request label Mar 21, 2023
@zhenghh04 zhenghh04 merged commit 456af95 into argonne-lcf:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants