-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For X86 and AMD machines, we can create a pip based dlio installations #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason you change the folder name from src to dlio_benchmark?
Yes, when we install using setup.py, the package which was earlier src was getting copied into the site-packages. I was looking at other python packages such as hydra and noticed their top level is called the same as the package name for the reason of installation purposes. That is why I change it that way. |
1. Fixed setup to install post processor. 2. Fixed CI to not set PYTHONPATH
…mark-1 into build-fix
88bfd36
to
e897c9c
Compare
I fixed the following.
|
I saw some extra files are been added to the repo, such as ./build, ./hydra_log. Could you clean that up? |
@zhenghh04 Fixed. |
1. created setup.py 2. fix root drectory to dlio_benchmark 3. renamed dlio_benchmark.py to main.py 4. renamed dlio_postprocessor.py to postprocessor.py 5. fixed documentation to use dlio_benchmark and dlio_postprocessor entry points.
689f4b5
to
1be84f1
Compare
Building an installable package needs the following features
With these changes, users can do
pip install .
to install the dependencies and main dlio_benchmark as an installation script and copy it to the bin. Allowing users to execute the benchmark usingdlio_benchmark -h
.