Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For X86 and AMD machines, we can create a pip based dlio installations #66

Merged
merged 20 commits into from
Jun 20, 2023

Conversation

hariharan-devarajan
Copy link
Collaborator

Building an installable package needs the following features

  • Correct source folder name. It should not be src but the project name.
  • Then, the data files being part of the package is recommended. E.g., configs.
  • adding namespace files i.e., init.py, in all module files. This will help set up files to copy the correct namespaces and module files.
  • Fix the main benchmark module from dlio_benchmark.py to benchmark.py.

With these changes, users can do pip install . to install the dependencies and main dlio_benchmark as an installation script and copy it to the bin. Allowing users to execute the benchmark using dlio_benchmark -h.

@hariharan-devarajan hariharan-devarajan self-assigned this May 27, 2023
@hariharan-devarajan hariharan-devarajan marked this pull request as draft May 28, 2023 00:02
Copy link
Member

@zhenghh04 zhenghh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you change the folder name from src to dlio_benchmark?

@hariharan-devarajan
Copy link
Collaborator Author

Any particular reason you change the folder name from src to dlio_benchmark?

Yes, when we install using setup.py, the package which was earlier src was getting copied into the site-packages. I was looking at other python packages such as hydra and noticed their top level is called the same as the package name for the reason of installation purposes. That is why I change it that way.

@hariharan-devarajan hariharan-devarajan marked this pull request as ready for review June 1, 2023 20:27
@hariharan-devarajan hariharan-devarajan added the enhancement New feature or request label Jun 5, 2023
@hariharan-devarajan hariharan-devarajan force-pushed the build-fix branch 3 times, most recently from 88bfd36 to e897c9c Compare June 20, 2023 03:00
@hariharan-devarajan
Copy link
Collaborator Author

@zhenghh04

I fixed the following.

  1. refactored benchmark and postprocesser script.
  2. fixed documentation.

@zhenghh04
Copy link
Member

@zhenghh04

I fixed the following.

  1. refactored benchmark and postprocesser script.
  2. fixed documentation.

I saw some extra files are been added to the repo, such as ./build, ./hydra_log. Could you clean that up?

@hariharan-devarajan
Copy link
Collaborator Author

@zhenghh04 Fixed.

1. created setup.py
2. fix root drectory to dlio_benchmark
3. renamed dlio_benchmark.py to main.py
4. renamed dlio_postprocessor.py to postprocessor.py
5. fixed documentation to use dlio_benchmark and dlio_postprocessor entry points.
@zhenghh04 zhenghh04 merged commit 9f5a8db into argonne-lcf:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants