Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image with CPU only dependencies #8

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

johnugeorge
Copy link
Contributor

In this PR

  1. Versions of packages are frozen in requirements file for reproducibility
  2. CPU version of Dockerfile is added with no GPU dependencies

Docker file installation steps match the GitHub action DLIO installation

@johnugeorge
Copy link
Contributor Author

@jovonho

@johnugeorge johnugeorge changed the title Add docker image for CPU version Add docker image for CPU only dependencies Nov 22, 2022
@johnugeorge johnugeorge changed the title Add docker image for CPU only dependencies Add docker image with CPU only dependencies Nov 22, 2022
Copy link
Contributor

@lhovon lhovon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zhenghh04
Copy link
Member

zhenghh04 commented Nov 22, 2022

@johnugeorge Are you able to check whether the dockerfile works in MacOSX?

When I was running with bare metal version, there was some issue with iostat profiling in MacOSX system. Let us make sure this works before adding that to the dockerfile.

@johnugeorge
Copy link
Contributor Author

@johnugeorge Are you able to check whether the dockerfile works in MacOSX?

When I was running with bare metal version, there was some issue with iostat profiling in MacOSX system. Let us make sure this works before adding that to the dockerfile.

@zhenghh04 Sorry, I didn't catch your comment on MacOSX. IOStat is installed inside the debian docker container right? I assume, Github actions VM image already has IOStat installed in it for profiling.

I was using MacOSX to build the image. I tried

mpirun -n 2 python ./src/dlio_benchmark.py workload=unet3d ++workload.framework=tensorflow ++workload.data_reader.data_loader=tensorflow ++workload.train.computation_time=0.05 ++workload.evaluation.eval_time=0.01 ++workload.train.epochs=2 ++workload.workflow.train=False ++workload.workflow.generate_data=True ++workload.dataset.num_files_train=16 ++workload.dataset.num_files_eval=4
mpirun -n 2 python ./src/dlio_benchmark.py workload=unet3d ++workload.framework=tensorflow ++workload.data_reader.data_loader=tensorflow ++workload.train.computation_time=0.05 ++workload.evaluation.eval_time=0.01 ++workload.train.epochs=2 ++workload.workflow.train=True ++workload.workflow.generate_data=False ++workload.dataset.num_files_train=16 ++workload.dataset.num_files_eval=4
inside docker and it works. Anything else to be verified?

@zhenghh04 zhenghh04 self-requested a review November 22, 2022 20:06
@zhenghh04 zhenghh04 merged commit fa7a954 into argonne-lcf:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants