Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Log appset version during controller startup #241

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

chetan-rns
Copy link
Member

Display the version of applicationset and git commit ID during controller startup log

Closes: #169

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question re: version string, then good to go.

common/version.go Outdated Show resolved Hide resolved
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks again @chetan-rns!

@jgwest jgwest merged commit 8d3fa24 into argoproj:master Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'VERSION' file contents and latest commit ID to controller startup
2 participants