This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
fixes RepoHasPath error handling #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In trhe case that gitlab is unreachable previous code would return no error , thus filtering out the app from the desired apps. This is not a wanted behaviour as the check could not be performed correctly
|
|
|
Would be great to have this PR reviewed ! (and even greater if it could make the v0.3.0 release 🚀) |
jgwest
approved these changes
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that gitlab is unreachable , RepoHasPath would return false with NO error , thus filtering out the app from the "desired apps". This is not a wanted behaviour as the check could not be performed correctly.
The fixes checks the error from ListTree first, then checks the results.