Fixes GitLab RepoHasPath error handling (#423)

In trhe case that gitlab is unreachable previous code would return no error , thus filtering out the app from the desired apps. This is not a wanted behaviour as the check could not be performed correctly
argoproj · Dec 1, 2021 · ce12bd5 · ce12bd5
1 parent c574f5e
commit ce12bd5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/services/scm_provider/gitlab.go b/pkg/services/scm_provider/gitlab.go
@@ -95,12 +95,12 @@ func (g *GitlabProvider) RepoHasPath(_ context.Context, repo *Repository, path s
  Path: &path,
  Ref: &repo.Branch,
  })
- if resp.TotalItems == 0 {
- return false, nil
- }
  if err != nil {
  return false, err
  }
+ if resp.TotalItems == 0 {
+ return false, nil
+ }
  return true, nil
 }