Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert existing unit test to ginkgo in controlller package #37

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Rizwana777
Copy link
Collaborator

What does this PR do / why we need it:

  • Converted existing unit tests to Ginkgo tests in controller package

Issue #27

Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@jgwest jgwest merged commit 2aba8a0 into argoproj-labs:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants