Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric and traffic plugins in Argo Rollouts #90

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Rizwana777
Copy link
Collaborator

@Rizwana777 Rizwana777 force-pushed the issue-4217 branch 3 times, most recently from 138b5e3 to 0d829de Compare September 13, 2024 11:42
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
@jparsai
Copy link
Collaborator

jparsai commented Sep 30, 2024

/lgtm

controllers/configmap.go Outdated Show resolved Hide resolved
controllers/configmap.go Outdated Show resolved Hide resolved
controllers/configmap.go Show resolved Hide resolved
api/v1alpha1/argorollouts_types.go Outdated Show resolved Hide resolved
controllers/configmap.go Outdated Show resolved Hide resolved
controllers/configmap_test.go Show resolved Hide resolved
tests/e2e/cluster-scoped/cluster_scoped_rollouts_test.go Outdated Show resolved Hide resolved
tests/e2e/cluster-scoped/cluster_scoped_rollouts_test.go Outdated Show resolved Hide resolved
tests/e2e/cluster-scoped/cluster_scoped_rollouts_test.go Outdated Show resolved Hide resolved
tests/e2e/cluster-scoped/cluster_scoped_rollouts_test.go Outdated Show resolved Hide resolved
@Rizwana777 Rizwana777 force-pushed the issue-4217 branch 2 times, most recently from 1ff9dcb to c5dc239 Compare October 1, 2024 11:40
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Rizwana777!

One more request, would you be able to add an example of this feature to this file: https://github.com/argoproj-labs/argo-rollouts-manager/blob/main/docs/crd_reference.md
We've been doing this for the other features we've added, as well.

I also added a few minor nits I noticed while reviewing, then good to go.

controllers/configmap_test.go Show resolved Hide resolved
controllers/configmap_test.go Outdated Show resolved Hide resolved
tests/e2e/rollout_tests_all.go Outdated Show resolved Hide resolved
controllers/configmap.go Outdated Show resolved Hide resolved
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
@Rizwana777
Copy link
Collaborator Author

Addressed all the comments @jgwest PTAL

Signed-off-by: Jonathan West <jonwest@redhat.com>
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@jgwest jgwest merged commit f36a278 into argoproj-labs:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native support for traffic/metrics plugins in Argo Rollouts
3 participants