Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition on metrics plugin E2E test #99

Merged

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Nov 1, 2024

What does this PR do / why we need it:

Fix this intermittent error in metrics E2E test:

------------------------------
• [FAILED] [22.256 seconds]
Namespace-scoped RolloutManager tests RolloutManager tests - namespace-scoped [It] Should add, update, and remove traffic and metric plugins through RolloutManager CR
/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/tests/e2e/rollout_tests_all.go:600

  Timeline >>
  STEP: Verify that RolloutManager is successfully created. @ 10/31/24 08:09:26.89
  STEP: Verify traffic and metric plugin is added to ConfigMap @ 10/31/24 08:09:38.014
  STEP: Update traffic and metric plugins @ 10/31/24 08:09:38.019
  STEP: Get existing Rollouts Pod(s) before update @ 10/31/24 08:09:38.022
  STEP: Verify traffic and metric plugin is updated in ConfigMap @ 10/31/24 08:09:38.04
  STEP: Remove traffic and metric plugins @ 10/31/24 08:09:38.042
  STEP: Remove plugins from RolloutManager CR @ 10/31/24 08:09:38.044
  STEP: Verify that traffic and metric plugins are removed from ConfigMap @ 10/31/24 08:09:38.057
  STEP: Get existing Rollouts Pod(s) after update @ 10/31/24 08:09:39.062
  STEP: Verify Rollouts Pod is restarted @ 10/31/24 08:09:39.066
  [FAILED] in [It] - /home/runner/work/argo-rollouts-manager/argo-rollouts-manager/tests/e2e/rollout_tests_all.go:687 @ 10/31/24 08:09:39.077
  << Timeline

  [FAILED] Expected
      <[]v1.Pod | len:2, cap:2>: [
          {
              TypeMeta: {Kind: "", APIVersion: ""},
              ObjectMeta: {
                  Name: "argo-rollouts-ddccf95db-bw89k",
                  GenerateName: "argo-rollouts-ddccf95db-",
                  Namespace: "argo-rollouts",
                  SelfLink: "",
                  UID: "bfc185e8-7e42-474b-ab00-49aacb898e1f",
                  ResourceVersion: "3729",


(...)

  to have length 1
  In [It] at: /home/runner/work/argo-rollouts-manager/argo-rollouts-manager/tests/e2e/rollout_tests_all.go:687 @ 10/31/24 08:09:39.077
------------------------------

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

Which issue(s) this PR fixes:
Fixes #?

How to test changes / Special notes to the reviewer:

@jgwest jgwest requested a review from Rizwana777 November 1, 2024 08:41
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest force-pushed the fix-plugin-e2e-test-race-condition-oct-2024 branch from 38c7506 to 4a3a62e Compare November 1, 2024 08:42
Copy link
Collaborator

@Rizwana777 Rizwana777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a minot comment, else LGTM

tests/e2e/fixture/k8s/fixture.go Outdated Show resolved Hide resolved
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Copy link
Member Author

jgwest commented Nov 7, 2024

Thanks @Rizwana777!

@jgwest jgwest merged commit 9f79ece into argoproj-labs:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants