feat: update several path for image.tag

[Tchoupinax]

Hello folks!

I made this improvement to handle a case we have at work. Let's explain it.

In the current case, we provide a path for the image tag with the annotation .helm.image-tag. It says where to update the tag for this argoCD application.

Now, I have one ArgoCD application with two deployements, different with a suffix. Let's call them a and b. So my helm-chart values are prefixed by the alias of each app.

a:
  image:
    tag: v1.0.0

b:
  image:
    tag: v1.0.0

I want to update both at the same time, the lifecycle is identical. This merge request allows to do it, by adding several paths as value separated by a comma. Then, I can provide

xxxx.helm.image-tag=a.image.tag,b.image.tag

A unit test has been added about tag and name and moreover, I handled every space to ensure it won't have any bug for a mistype.

Finally, I build the customized image and tested, all is OK for me.
I hope all is clear!

Thank you for your work, I love this project.
Cheers!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.92%. Comparing base (4f21ade) to head (175777e).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   74.82%   74.92%   +0.10%     
==========================================
  Files          31       31              
  Lines        3912     3928      +16     
==========================================
+ Hits         2927     2943      +16     
  Misses        850      850              
  Partials      135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chengfang]

@Tchoupinax thanks for proposing it. I'll look into it.

[Tchoupinax]

Hello @chengfang,
Could you have time to give a look again? 🙏

[chengfang]

any reason hpImageSpec is not updated to take multiple values too? Do we want to keep image.spec, image.name, and image.tag consistant in taking multi-path values?

[chengfang]

Some other places assume that image.name and image.spec represent single-path value, and we should think about if it makes sense for those places to also take multi-path values. For instance,

argocd-image-updater/pkg/argocd/update.go

Line 449 in 4f21ade

helmAnnotationParamName, helmAnnotationParamVersion := getHelmParamNamesFromAnnotation(app.Annotations, c)

argocd-image-updater/pkg/argocd/update.go

Line 473 in 4f21ade

helmParamName := getHelmParam(appSource.Helm.Parameters, helmAnnotationParamName)

[chengfang]

also need to handle cases like below to exclude empty slice elements caused by extra separators.
foobar.image.name,foobar2.image.name,
foobar.image.name,,,foobar2.image.name