Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Git write back to helm values is incorrect during the first pass and corrupts existing data #885

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: Git write back to helm values is incorrect during the first pass and corrupts existing data #885

merged 1 commit into from
Oct 18, 2024
+44 −1

Conversation

chengfang
Copy link
Collaborator

Closes #884

@chengfang
fix: Git write back to helm values is incorrect during the first pass…
ad1b614 
… and corrupts existing data

Signed-off-by: Cheng Fang <cfang@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (2e631b0) to head (ad1b614).

Files with missing lines Patch % Lines
pkg/argocd/update.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   75.53%   75.50%   -0.03%     
==========================================
  Files          31       31              
  Lines        3151     3156       +5     
==========================================
+ Hits         2380     2383       +3     
- Misses        636      637       +1     
- Partials      135      136       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@pasha-codefresh pasha-codefresh merged commit 4f21ade into argoproj-labs:master Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@jannfis jannfis Awaiting requested review from jannfis jannfis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git write back to helm values is incorrect during the first pass and corrupts existing data
4 participants
@chengfang @codecov-commenter @pasha-codefresh @ishitasequeira