Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address comments in PR #854 #886

Merged

Conversation

ishitasequeira
Copy link
Contributor

Address comments in #854.

Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (ad9648f) to head (09d0438).

Files with missing lines Patch % Lines
pkg/env/env.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   75.94%   75.95%   +0.01%     
==========================================
  Files          31       31              
  Lines        3184     3198      +14     
==========================================
+ Hits         2418     2429      +11     
- Misses        633      635       +2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang chengfang merged commit 3e7378a into argoproj-labs:master Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants